fix(docx): fix short-row DOCX table #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
changed the title
|
Fixes #709. |
cragwolfe
approved these changes
Apr 28, 2024
scanny
force-pushed
the
scanny/fix-docx-short-table-rows
branch
2 times, most recently
from
0db3eeb
to
7ce80df
Compare
scanny
force-pushed
the
scanny/fix-docx-short-table-rows
branch
from
7ce80df
to
25e29cd
Compare
scanny
force-pushed
the
scanny/bump-docx-dependency
branch
3 times, most recently
from
ce866d5
to
d3c9c7f
Compare
Version 1.1.1 of `python-docx` added "built-in" type support so we don't need these anymore.
scanny
force-pushed
the
scanny/fix-docx-short-table-rows
branch
from
25e29cd
to
49b4311
Compare
scanny
force-pushed
the
scanny/fix-docx-short-table-rows
branch
from
49b4311
to
15430c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The DOCX format allows a table row to start late and/or end early, meaning cells at the beginning or end of a row can be omitted. While there are legitimate uses for this capability, using it in practice is relatively rare. However, it can happen unintentionally when adjusting cell borders with the mouse. Accommodate this case and generate accurate
.textand.metadata.text_as_htmlfor these tables.