Make code NativeAOT compatible #1609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know that C# files are autogenerated, but in case somebody what to use it without waiting for change in code gen tooling. This PR has 3 changes, all of them trivially can be updated in the codegen: - `Marshal.SizeOf(Type)` switched to `Marshal.SizeOf<T>()` - `Marshal.PtrToStructure(IntPtr, Type)` to `Marshal.PtrToStructure<T>(IntPtr)` - `Marshal.PtrToStructure<string>(IntPtr)` is gross error, and should be mapped to `Marshal.PtrToStringAnsi(IntPtr)`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that C# files are autogenerated, but in case
somebody what to use it without waiting for change in code gen tooling.
This PR has 3 changes, all of them trivially can be updated in the codegen:
Marshal.SizeOf(Type)switched toMarshal.SizeOf<T>()Marshal.PtrToStructure(IntPtr, Type)toMarshal.PtrToStructure<T>(IntPtr)Marshal.PtrToStructure<string>(IntPtr)is gross error, and should be mapped toMarshal.PtrToStringAnsi(IntPtr)This and #707 should make life of C# developer, amenable and close #638 and #472.