1. vrcore -> vrcommon 2. AssertMsg -> cerr

[jiapei100]

1. vrcore -> vrcommon
2. AssertMsg -> cerr

[okawo80085]

1. is fine
2. is not fine, AssertMsg should keep being a function or at least a macro, it should not be replaced by std::cerr stream

[jiapei100]

1. is fine
2. is not fine, AssertMsg should keep being a function or at least a macro, it should not be replaced by std::cerr stream

Hi, @okawo80085

Look at this file: https://github.com/ValveSoftware/openvr/blob/master/samples/shared/strtools.cpp, all AssertMsg() have been commented out ...
So, the best option is to remove all AssertMsg() ????

[okawo80085]

Just no.

Just because it was removed from one place does not mean it should be removed from another, it's an assertive log, apart from logging it also plays a role of an assert, i.e. it seg faults the process.

Replacing it with just a log, which is not wrapped in anything and hurts flexibility, is plain wrong.