feat(plugin): yt-dlp integration

[TheColorman]

This is a plugin that adds a yt-dlp command. You pass a url, it downloads it and readies it as an attachment. See the gif for a quick example.

It supports any URL supported by https://github.com/yt-dlp/yt-dlp.

Warning:

This plugin has 2 dependencies: yt-dlp and ffmpeg. yt-dlp gets automatically downloaded and stored locally, but ffmpeg does not, and thus needs to be installed by the user.

I have not yet tested this on Linux, and I might also add support for converting directly to gifs, but feel free to experiment and find bugs.

[rozbrajaczpoziomow]

Doesn't work under Linux (probably missing execute perm)

Also, why redownload yt-dlp if it is already installed on the system? (like on mine)

[Vendicated]

i love this plugin idea!

however based on a quick skim of the code, the current implementation is very questionable. why is ytdlp stored in indexeddb? you need it on the native side, not in the browser

i honestly don't think the plugin should download it for you. why not simply test if it's available and if not show the user a popup with instructions how to install it?

installing programs from a plugin is not something I want to do and it might trip anti malware engines, not to mention that it also just seems a little sussy. and on Linux this should really be handled via package manager anyway

we could just have the user install python themselves and then use pip to install it if it's missing

[TheColorman]

@rozbrajaczpoziomow

Doesn't work under Linux (probably missing execute perm)

Nice catch, weird that it's interrupting though, I thought I had error handling everywhere. I'll have to take a look at that.

Also, why redownload yt-dlp if it is already installed on the system? (like on mine)

Good point, should probably add a check.

@Vendicated

however based on a quick skim of the code, the current implementation is very questionable. why is ytdlp stored in
indexeddb? you need it on the native side, not in the browser

I wanted to store it somewhere and wasn't sure where else to do it..

i honestly don't think the plugin should download it for you. why not simply test if it's available and if not show the user a popup with instructions how to install it?

Yeah that's fair enough. I wanted to make it completely seamless, but halfway through I realised that doing the same to download ffmpeg would be a pain in the ass, so now it's in a bit of a weird state where half of the dependencies auto-install. This definitely makes more sense.

we could just have the user install python themselves and then use pip to install it if it's missing

I'm not sure that would add it to PATH, would it? I've always had to manually add yt-dlp to the PATH unless I entered a Python venv.

[Vendicated]

anything installed via pip should be in path. when you install python on windows there's an option to add python stuff to the PATH, you need to make sure to have it checked

in any case, you could just do python3 -m yt-dlp or even write a small python script that imports the module and uses the api from python

[Sqaaakoi]

Doesn't work under Linux (probably missing execute perm)

Also, why redownload yt-dlp if it is already installed on the system? (like on mine)

it's running the windows version??

[Scyye]

Also, does this work on the web version?; if not, id mark it as such.

[rozbrajaczpoziomow]

lemme make you think about it for 1 second - if it has to download yt-dlp/ffmpeg locally, run child_process...

[Scyye]

lemme make you think about it for 1 second - if it has to download yt-dlp/ffmpeg locally, run child_process...

that was my point lol

[TheColorman]

@Scyye

Also, does this work on the web version?; if not, id mark it as such.

How do I mark it as desktop only? I think I've seen a plugin or two using the .desktip.(ts/tsx) extension, is that sufficient?

[Scyye]

@Scyye

Also, does this work on the web version?; if not, id mark it as such.

How do I mark it as desktop only? I think I've seen a plugin or two using the .desktip.(ts/tsx) extension, is that sufficient?

rename the folder to pluginname.desktop im pretty sure

[TheColorman]

With 8bc793c it should only build for desktop.