Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replaceGoogleSearch): trim LF character #2488

Closed
wants to merge 2 commits into from

Conversation

Mylloon
Copy link
Contributor

@Mylloon Mylloon commented May 20, 2024

Trim LF character when doing a search

@Vendicated
Copy link
Owner

what problem exactly does this solve?

@Mylloon
Copy link
Contributor Author

Mylloon commented May 21, 2024

Sometimes when doing a search there is a %0A at the end

@j4k0xb
Copy link

j4k0xb commented May 22, 2024

There can also be a new line at the start

what problem exactly does this solve?

duckduckgo errors, most other search engines ignore it

@lewisakura
Copy link
Sponsor Collaborator

There can also be a new line at the start

Shouldn't it be .trim() then?

Vendicated added a commit that referenced this pull request May 26, 2024
- FriendsSince: Don't show for friend requests
- FakeNitro: Fix attempting to bypass unicode emojis #2503
- MessageLatency: ignore bots #2504
- CtrlEnterSend: use cmd+enter on macOS #2502
- ReplaceGoogleSearch: trim LF character #2488

Co-authored-by: AutumnVN <autumnvnchino@gmail.com>
Co-authored-by: rushiiMachine <33725716+rushiiMachine@users.noreply.github.com>
Co-authored-by: Lumap <lumap@duck.com>
Co-authored-by: Mylloon <kennel.anri@tutanota.com>
@Vendicated
Copy link
Owner

Thanks! Pushed via c836270

@Vendicated Vendicated closed this May 26, 2024
ImLvna pushed a commit to ImLvna/Vencord that referenced this pull request May 27, 2024
- FriendsSince: Don't show for friend requests
- FakeNitro: Fix attempting to bypass unicode emojis Vendicated#2503
- MessageLatency: ignore bots Vendicated#2504
- CtrlEnterSend: use cmd+enter on macOS Vendicated#2502
- ReplaceGoogleSearch: trim LF character Vendicated#2488

Co-authored-by: AutumnVN <autumnvnchino@gmail.com>
Co-authored-by: rushiiMachine <33725716+rushiiMachine@users.noreply.github.com>
Co-authored-by: Lumap <lumap@duck.com>
Co-authored-by: Mylloon <kennel.anri@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants