Refactor FakeNitro #2491
Open
Refactor FakeNitro #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for better maintainability and readability
|
Not sure this is the right place to ask, but are soundboard sounds server side or client side, and if they are client side, could fakenitro be expanded to support them? |
No, to all of those questions. |
Vendicated
force-pushed
the
dev
branch
2 times, most recently
from
3a25da5
to
05a4044
Compare
Nuckyz
force-pushed
the
dev
branch
2 times, most recently
from
c50208b
to
d8524b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what you think about this approach
And yes I did this all because of this comment
