Feature: [vmagent] added push data with zabbix connector

[SinotQ]

Description

Support receiving data from the Zabbix connector. (vmagent)

Added

• New path /zabbixconnector/api/v1/history
• New command-line flag:
  • -zabbixconnector.maxLineLen (similar to the -import.maxLineLen flag)
  • -zabbixconnector.addGroups (Enable adding Zabbix host groups to labels (group_name="1"))
  • -zabbixconnector.addEmptyTags (Enable adding Zabbix tags without values to labels (tag_name="1"))

Note

• Labels:
  • The metric name is added to the __name__ label.
  • Host name to host label.
  • Visible name to hostname label.
• The returned response complies with the requirements of the Zabbix Connector protocol.
• Support sending item numeric values only.

Otherwise, I tried to adhere to the functionality of /api/v1/import

Useful links:

• Zabbix Streaming to external systems (https://www.zabbix.com/documentation/current/en/manual/config/export/streaming)
• Zabbix Newline-delimited JSON expor (https://www.zabbix.com/documentation/current/en/manual/appendix/protocols/real_time_export)

[zekker6]

Hello @SinotQ, thank you for the PR!

Please, see a few comments/questions.
Disclaimer: I'm not very familiar with Zabbix, so there are mostly questions about logic in parser which might be specific to Zabbix.

Also, it would be great if you could update documentation to include an instruction on how to use this integration with Zabbix. This is not mandatory, but will be much appreciated.
See this part of documentation for an example - https://docs.victoriametrics.com/single-server-victoriametrics/#how-to-send-data-from-newrelic-agent

[zekker6]

Could you share a use-case when empty labels must be kept?

[SinotQ]

Zabbix allows tags without values. Various filtering rules and conditions in Zabbix also support tags without values. Perhaps someone might use this feature and want to see similar tags as labels in VicotriaMetrics.

I missed something when implementing Zabbix Connector support. Zabbix supports the same tag names with different values for the same element. For example:

service
service: mysql 
service: critical

How could this be implemented in VicotriaMetrics? (service: empty,mysql,critical)

https://www.zabbix.com/documentation/current/en/manual/config/tagging
https://www.zabbix.com/documentation/current/en/manual/config/notifications/action/conditions

[zekker6]

For such tags I would suggest creating separate labels:

tag_service_mysql: "present"
tag_service_critical: "present"

# or 

# this is similar to how k8s discovery handles such cases
tag_present_service_mysql: "true"
tag_present_service_critical: "true"

[codecov]

Codecov Report

Attention: Patch coverage is 47.77070% with 164 lines in your changes are missing coverage. Please review.

Project coverage is 58.20%. Comparing base (8aaa828) to head (17b1f26).
Report is 755 commits behind head on master.

Files	Patch %	Lines
...protoparser/zabbixconnector/stream/streamparesr.go	0.00%	96 Missing ⚠️
app/vmagent/zabbixconnector/request_handler.go	0.00%	44 Missing ⚠️
app/vmagent/main.go	0.00%	20 Missing ⚠️
lib/protoparser/zabbixconnector/parser.go	97.40%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
- Coverage   60.37%   58.20%   -2.18%     
==========================================
  Files         411      612     +201     
  Lines       76609    83144    +6535     
==========================================
+ Hits        46253    48393    +2140     
- Misses      27794    31530    +3736     
- Partials     2562     3221     +659     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.