Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/streamaggr: removed unused resetState arg #6232

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndrewChubatiuk
Copy link
Contributor

Describe Your Changes

resetState is set to true everywhere in a source code except tests. Removing it

Checklist

The following checks are mandatory:

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 57.26%. Comparing base (8aaa828) to head (2a84e90).
Report is 649 commits behind head on master.

❗ Current head 2a84e90 differs from pull request most recent head e2f5cff. Consider uploading reports for the commit e2f5cff to get more accurate results

Files Patch % Lines
lib/streamaggr/streamaggr.go 50.00% 9 Missing ⚠️
lib/streamaggr/unique_samples.go 0.00% 3 Missing ⚠️
lib/streamaggr/total.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6232      +/-   ##
==========================================
- Coverage   60.37%   57.26%   -3.12%     
==========================================
  Files         411      527     +116     
  Lines       76609    72643    -3966     
==========================================
- Hits        46253    41597    -4656     
- Misses      27794    28128     +334     
- Partials     2562     2918     +356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hagen1778
Copy link
Collaborator

hagen1778 commented May 8, 2024

resetState is set to true everywhere in a source code except tests. Removing it

Looks like it is indeed the only purpose - see 6319d02.

Let's keep it, as it will affect benchmark results. I don't know why it is not implemented via global variable, though. It looks like global var set to true in tests could involve less changes.

@AndrewChubatiuk
Copy link
Contributor Author

interesting
is there any reason to use sync.Map for all aggregators except total?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants