Bump actions/download-artifact from 3 to 4

[dependabot]

Bumps actions/download-artifact from 3 to 4.

Release notes

Sourced from actions/download-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

• @​bflad made their first contribution in actions/download-artifact#194

Full Changelog: actions/download-artifact@v3...v4.0.0

v3.0.2

• Bump @actions/artifact to v1.1.1 - actions/download-artifact#195
• Fixed a bug in Node16 where if an HTTP download finished too quickly (<1ms, e.g. when it's mocked) we attempt to delete a temp file that has not been created yet Migrate dev environment and workflows to node16  actions/toolkit#1278

v3.0.1

• Bump @​actions/core to 1.10.0

Commits

• 7a1cd32 Merge pull request #246 from actions/v4-beta
• 8f32874 licensed cache
• b5ff844 Merge pull request #245 from actions/robherley/v4-documentation
• f07a0f7 Update README.md
• 7226129 update test workflow to use different artifact names for matrix
• ada9446 update docs and bump @​actions/artifact
• 7eafc8b Merge pull request #244 from actions/robherley/bump-toolkit
• 3132d12 consume latest toolkit
• 5be1d38 Merge pull request #243 from actions/robherley/v4-beta-updates
• 465b526 consume latest @​actions/toolkit
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[juntao]

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

---

Commit fdb24d8a36b1ef0677736010a8b121162b9c37e6

Patch Summary:

This pull request updates the version of actions/download-artifact from version 3 to 4. This GitHub action is used to download build artifacts uploaded by the upload-artifact action, which are referenced via uses: actions/download-artifact@v4. The version change happened in two files: .github/workflows/build_for_openwrt.yml and .github/workflows/release.yml. In the case of build_for_openwrt.yml, the action is intended to download an image, while in release.yml, it fetches a tarball.

Potential Issues:

1. Compatibility: A major version change implies breaking changes. There might be compatibility issues with the new version. The developer must verify that version 4 of actions/download-artifact functions as expected in this context.

2. Dependencies: Any dependencies that rely on actions/download-artifact might behave unpredictably, given that changes in major versions can introduce instability.

3. Unforeseen Errors: It's important to check the release notes for this version bump to ensure there are no new errors or issues introduced by this version.

Recommendations:

The developer should ensure the application works as expected after the version bump. It is also advised to thoroughly test the workflow where these downloads are utilized before merging the pull request. Checking the release notes for the new version from the official GitHub page of the download-artifact action may offer more insights to potential problems or added functionalities.

[hydai]

This is blocked by #3099. We should merge this after the #3099 gets merged.