-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component model] instantiate #3218
base: master
Are you sure you want to change the base?
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
98f8cf5
to
0524918
Compare
263b7e6
to
1ae315b
Compare
702105e
to
2ee0a0e
Compare
ad0d330
to
cc50f42
Compare
0c1460e
to
749d4c3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
8c2d59d
to
7644092
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
- Coverage 79.83% 77.76% -2.08%
==========================================
Files 253 262 +9
Lines 34948 35902 +954
Branches 6128 6442 +314
==========================================
+ Hits 27902 27919 +17
- Misses 5616 6547 +931
- Partials 1430 1436 +6 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
44b2deb
to
369906b
Compare
aa1d588
to
f51430d
Compare
edf18b4
to
fa0f78c
Compare
905e4b6
to
3db5ac9
Compare
@hydai The bug is fixed, with update branch this should be ready to be merged. |
@dannypsnl Please rebase to the latest master. |
* section order will affect index space * skip validation process for now * nested core module instantiation * record all environments had been used * add type and core:type into index space (in component instance) * (FIXME) import section: the current implementation will treat a plugin as module instance instead a component instance, in the end we should have both * instantiate component sort part * export function instance out, so we can run it from CLI * canoncial lift without options * canoncial lower without options * unify component and module instance in VM * drafting inline exports concept Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
* wasi-http implementation * drafting example for test * fix a bug in store manager, soft modules do it wrong * fix instance problem misc * update to follow review feedback * mark TODO * add prefix * reinterpret_cast * format stuff Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
- canonical changes - extracting out the instantiate of each section to its own file - `alias` is correct, the bug is coming from the demo code Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
1. [component] create `Executor::lowering` function that gets a higher function instance, returns a lower function instance 2. add enum `TypeCode::String` 3. add `StrVariant` so host function can operate string 4. [plugin] update wasi-http implementation to use new stuffs Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
* pushing canonical lifting a bit, now call flow has no error came out * add header * cannot allocate ValVariant * `vector` of component instance use push_back * fix test build * remove const descriptor * avoid occurs casting which will fail on some platforms * remove `const` * proper initialize * anonymous namespace * lift lower function that occurs string correctly misc * mark TODO * use hard code version to allocate string in memory * abort execution if run into unimplemented option * add formatter for AST type * use formatter Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
misc * complete defined value type formatter * format the Component function type Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
NOTE: some internal bugs still there, so the demo haven't fully work yet. Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
misc: remove unused code Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
misc * missing `break` in cases * adjustment Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
…ng content misc * missing `break` * reduce interface of `StrVariant` Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
misc: format Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>
3db5ac9
to
256fac7
Compare
@hydai rebased. |
#3151
AST::FunctionType