Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASI-NN] neural_speed: add backend structure #3303

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

[WASI-NN] neural_speed: add backend structure #3303

wants to merge 18 commits into from

Conversation

grorge123
Copy link

No description provided.

@juntao Flows.network Integration
Copy link
Member

juntao commented Mar 25, 2024 •
edited

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

@github-actions github-actions bot added c-Plugin An issue related to WasmEdge Plugin c-WASI-NN c-CMake labels Mar 25, 2024
@grorge123 grorge123 force-pushed the neural_speed branch 4 times, most recently from f916aeb to af7d519 Compare March 25, 2024 11:53
@grorge123 grorge123 requested a review from q82419 as a code owner March 25, 2024 11:53
@github-actions github-actions bot added the c-Test An issue/PR to enhance the test suite label Mar 25, 2024
@github-actions github-actions bot removed the c-Test An issue/PR to enhance the test suite label Mar 25, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.84%. Comparing base (5a65509) to head (4cf1f5e).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3303   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files         253      253           
  Lines       34948    34948           
  Branches     6138     6114   -24     
=======================================
+ Hits        27902    27905    +3     
+ Misses       5625     5619    -6     
- Partials     1421     1424    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grorge123 grorge123 marked this pull request as draft March 25, 2024 12:55
@grorge123 grorge123 marked this pull request as ready for review March 29, 2024 06:22
@grorge123 grorge123 changed the title [WIP] [WASI-NN] neural_speed: add backend struct [WASI-NN] neural_speed: add backend structure Mar 29, 2024
@grorge123 grorge123 requested a review from hydai as a code owner April 8, 2024 06:35
@github-actions github-actions bot added the c-Test An issue/PR to enhance the test suite label Apr 8, 2024
@github-actions github-actions bot added c-CLI An issue related to WasmEdge CLI tools c-Installer c-CI labels Apr 25, 2024
@github-actions github-actions bot removed c-CLI An issue related to WasmEdge CLI tools c-Installer c-CI labels Apr 25, 2024
@grorge123 grorge123 force-pushed the neural_speed branch 3 times, most recently from a60159f to 984d13a Compare April 25, 2024 04:06
@grorge123 grorge123 force-pushed the neural_speed branch 4 times, most recently from ef72299 to 065fc95 Compare May 13, 2024 07:19
@hydai hydai added the v-0.14.1 label May 22, 2024
hydai
hydai requested changes May 31, 2024
View reviewed changes
plugins/wasi_nn/CMakeLists.txt Outdated Show resolved Hide resolved
plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
test/plugins/wasi_nn/CMakeLists.txt Outdated Show resolved Hide resolved
test/plugins/wasi_nn/wasi_nn.cpp Outdated Show resolved Hide resolved
@grorge123
[WASI-NN] neural_speed: add backend struct
3bb5303 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
test: add successful test
628c6d4 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
feat: implement neural network backend
84859e8 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: neural backend and basic test
2e4d4ea 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: update pythonlib and share library
a4a6d6a 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
feat: add setting model type
82ae414 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: python finalize deadlock
1d1c152 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
test: add successful test
fa68cb9 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
feat: update build neural speed cmake
e30bdaf 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
feat: aneural speed backend ad unload function
405e4f8 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: simdjson not fund
f1a6851 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: remove finiSingle and set simdjson tags/v3.9.1
ff5826a 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
feat: print run time
c973cda 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: change time to chrono
ca859d1 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
fix: windows dlopen
37c4a65 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
test: add more test
acc887c 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural_speed: change simdjson and small model
25be440 
Signed-off-by: grorge <g97116@yahoo.com>
hydai
hydai requested changes Jun 2, 2024
View reviewed changes
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think we should also add the workflow to build and upload the assets.

plugins/wasi_nn/neuralspeed.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the c-CI label Jun 3, 2024
@grorge123
[WASI-NN] neural_speed: Add build workflow
4cf1f5e 
Signed-off-by: grorge <g97116@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm4 dm4 dm4 requested changes

@hydai hydai hydai requested changes

@ibmibmibm ibmibmibm Awaiting requested review from ibmibmibm ibmibmibm is a code owner

@q82419 q82419 Awaiting requested review from q82419 q82419 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
c-CI c-CMake c-Plugin An issue related to WasmEdge Plugin c-Test An issue/PR to enhance the test suite c-WASI-NN v-0.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grorge123 @juntao @dm4 @hydai