fixes no response being send on download #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to version 1.3.1, no file download response was triggered when calling the download function, which may result in empty pdf files #31.
This is due to the new use of the "Illuminate\Http\Response" class inside of the
download
method.The reason for the problem is that the response is generated and returned but not sent. To do this, we have to call the
send
method of the response class.This solves the problem!
(tested on laravel 9)