Make the website look cool and modern. #39
Conversation
JoshuaBrest
commented
May 15, 2024
JoshuaBrest
commented
|
Maintainers, please don't merge this yet. I noticed some vestigial CSS and would like to fix it before it gets merged |
|
Fixed! |
| <div class="menu-bar-inner menu-bar-left"> | ||
| <label id="sidebar-toggle" for="sidebar-toggle-anchor" class="menu-bar-button" | ||
| title="Toggle Table of Contents" aria-label="Toggle Table of Contents" aria-controls="sidebar"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -960 960 960" fill="currentColor"> |
There was a problem hiding this comment.
Don't just dump the whole SVG here
There was a problem hiding this comment.
I don't really like font awesome 4.0. Where else should I put the SVG? I prefer keeping it in line because it allows me to use the current color attribute. I don't have to statically set the color.
| @@ -0,0 +1,98 @@ | |||
| @font-face { | |||
There was a problem hiding this comment.
Should use the same fonts as the main site.
There was a problem hiding this comment.
The original website font is just the system font. I chose Rubik because it looks nice. Could we consider changing the font? Of course, I'm fine changing it back.
|
|
||
| /* When checked */ | ||
| #sidebar-toggle-anchor:checked + .page-wrapper .page { | ||
| border-radius: 2rem 0 0 0; |
There was a problem hiding this comment.
This radius doesn't persist when the page is scrolled, which is a little weird IMO.
There was a problem hiding this comment.
This radius doesn't persist when the page is scrolled, which is a little weird IMO.
I'm trying to come up with ways to correct this. My first thought is using a pseudo element.
