Add support for pasting the entire 2FA code #225
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKiazyk
requested changes
May 20, 2022
There was a problem hiding this comment.
Thanks @alexisakers!
This really shows that MacOS needs a way to copy/paste the Trusted Device 2FA code!
Looks and works great - just one small #picky change.
|
|
||
| // If we are focused on the first field and pasting a 6-digit string, | ||
| // treat it as pasting the entire code and focus on the last field | ||
| if code.isEmpty && newFieldText.count == numberOfDigits { |
There was a problem hiding this comment.
I think we can remove the isEmpty check and just add a check to make sure you are on the first character field instead. That way, as long as you're on the first field, you can paste the 6 digits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This PR adds support for pasting the entire 2FA code if the new string equals the length of the expected 2FA code. Currently, when pasting the 2FA code, only the last digit gets pasted.
Notes
I think it makes sense to have this behavior only if the user didn't enter any digit so that we can avoid any weird edge cases that could override their input, but let me know if you disagree.
Demo
Screen.Recording.2022-05-17.at.10.18.02.AM.mov