Resolve concurrency check warning on Swift 5.10 #522
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LiYanan2004 can you clean up this PR so it just includes the concurrency check since the other change was already merged in via #521 |
|
@MattKiazyk Hi, thanks for mentioning this. It's my fault. I have cleaned the PR to only contains swift-5.10 concurrency fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.10 introduces stricter concurrency check which adds one more warning
Reference to captured var 'progress' in concurrently-executing code; this is an error in Swift 6.Because progress update is based on Notification and operates on
OperationQueue.main, so we don't need to worry about data races.So I opt-out concurrency check here by using
nonisolated(unsafe)