Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update openai version to v1 & add image eval feature #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

uni-zhuan
Copy link
Contributor

@uni-zhuan uni-zhuan commented Nov 11, 2023

[WIP]

  • Test demos and verify stability

[DONE]

  • Update openai version to v1.1.1, modify API functions
  • Tested headline and animal demo, which are stable.
  • Remove Litellm for now, waiting for an stable update
    -------------------------commit [6e93038]

[WIP]

  • Waiting for litellm stable version

[DONE]

  • modify MultimodalOutput image schema
  • add openai_based_image_eval feature
  • add a new demobuilding_design to test image eval
    --------------------------commit [3db4a85]

@uni-zhuan uni-zhuan changed the title [WIP] update openai version to v1 [WIP] update openai version to v1 & add image eval feature Nov 14, 2023
Copy link

@motin motin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions:

  • Split this PR into one that updates the OpenAI client and another one for adding an image eval feature
  • Instead of removing litellm, convert existing demos etc to use an updated version of litellm so that there are no hard coded uses of the old OpenAI client. This makes it trivial to update the OpenAI version since it there will less outdated code to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants