-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hyperlinks rendering in tables #3599
base: develop
Are you sure you want to change the base?
Conversation
Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:
Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general a good idea, but it would be great if you could check my suggestion if that works as well, as it's then less prone to break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes making the code more efficient & readable
source/common/modules/markdown-editor/table-editor/table-editor.ts
Outdated
Show resolved
Hide resolved
source/common/modules/markdown-editor/table-editor/table-editor.ts
Outdated
Show resolved
Hide resolved
source/common/modules/markdown-editor/table-editor/table-editor.ts
Outdated
Show resolved
Hide resolved
source/common/modules/markdown-editor/table-editor/table-editor.ts
Outdated
Show resolved
Hide resolved
I have updated it. |
create a function to add cma class to `a` tag remove href from `a` tag and add title with url
Description
This PR adds
cma
css class toa
tag when table is rendered. It also removeshref
attribute froma
tag and addstitle
attribute with links.Changes
table-editor.ts
file. Alla
tags selected then loop through the tags. Ifa
tag does not containcma
class then add the class to it.link-tooltips.ts
searchcma
class andtitle
to add tooltip on mouse hover. So,href
removed andtitle
added toa
tags.Zettlr/source/common/modules/markdown-editor/hooks/link-tooltips.ts
Lines 38 to 49 in f8d0ee7
Additional information
Closes #2213
Tested on: Windows 11