MG-1987 - Enable Entity Endpoints to Return Basic Info for non-admins. #2168

WashingtonKK · 2024-04-11T08:43:11Z

What type of PR is this?

This is a feature because it adds the capability for entity endpoints to return basic entity information for non privileged users.

What does this do?

This PR allows non-admin users to get basic information (name and id) from entities without needing any administrator privileges.

Which issue(s) does this PR fix/relate to?

Resolves Feature: Add username and domain name variables to ListInvitations Return value #1987

Have you included tests for your changes?

No

Did you document any new/modified feature?

Yes, I have updated the documentation for the new feature.

Notes

This can be used to fetch user names for invitations to allow user names to be acquired without needing admin privileges.

Signed-off-by: WashingtonKK washingtonkigan@gmail.com

auth/postgres/domains.go

users/service.go

users/postgres/clients.go

pkg/clients/postgres/clients.go

invitations/middleware/tracing.go

arvindh123 · 2024-04-18T14:07:25Z

@dborovcanin @rodneyosodo Do we want to return usernames + id in invitations request ?
Instead of this , In UI we can view the user basic info with id and cache the request .

auth/service.go

internal/groups/service.go

things/service.go

arvindh123

Do we need to expose things and groups for public access?

The related issue states only exposing user basic info and domain basic info to authenticated user

users/service.go

dborovcanin · 2024-05-18T17:46:36Z

auth/service_test.go

-			token:    accessToken,
-			domainID: "",
-			err:      nil,
+			desc:           "retrieve domain with empty domainID",


...domain id

dborovcanin · 2024-05-18T17:51:11Z

users/service.go

+	for i := range pg.Clients {
+		pg.Clients[i] = mgclients.Client{Name: pg.Clients[i].Name, ID: pg.Clients[i].ID}
+	}


for i, c := range pg.Clients { pg.Clients[i] = mgclients.Client{ID: c.ID, Name: c.Name} }

dborovcanin · 2024-05-18T17:51:16Z

users/service.go

@@ -483,6 +489,10 @@ func (svc service) ListMembers(ctx context.Context, token, objectKind, objectID
 		return mgclients.MembersPage{}, errors.Wrap(svcerr.ErrViewEntity, err)
 	}

+	for i := range cp.Clients {


Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Refactor tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update mocks Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Update mocks Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Get basic domain info Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Update invitation to query names: Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Use entity to hold domain and user Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refinements Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update retrieve all basic info Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> replace repo call with service filtering Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Update test Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> revert changes on invitations service Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix testsg Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> remove basic information from things and groups Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> add undocumented status code Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Enhance mocks and fix tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix linter and remove debug logs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> change member relation to permission Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

…#2168) Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

WashingtonKK self-assigned this Apr 11, 2024

WashingtonKK force-pushed the MG-1987 branch 5 times, most recently from 74b82b1 to a56bbc2 Compare April 17, 2024 09:38

WashingtonKK marked this pull request as ready for review April 17, 2024 09:46

WashingtonKK force-pushed the MG-1987 branch 2 times, most recently from cfc7d73 to 6abdf88 Compare April 17, 2024 11:10

WashingtonKK requested review from arvindh123 and rodneyosodo April 17, 2024 11:24

dborovcanin requested changes Apr 18, 2024

View reviewed changes

auth/postgres/domains.go Outdated Show resolved Hide resolved

rodneyosodo requested changes Apr 18, 2024

View reviewed changes

dborovcanin force-pushed the MG-1987 branch from 6abdf88 to 355cc47 Compare April 18, 2024 13:02

WashingtonKK force-pushed the MG-1987 branch 4 times, most recently from 64e04f8 to 472ff75 Compare April 22, 2024 08:02

WashingtonKK requested a review from rodneyosodo April 22, 2024 08:20

WashingtonKK changed the title ~~MG-1987 : Add domain and user names to invitations~~ MG-1987 - Enable Entity Endpoints to Return Basic Info for non-admins. Apr 22, 2024

WashingtonKK force-pushed the MG-1987 branch from bb3759d to d555445 Compare April 22, 2024 09:06

arvindh123 reviewed Apr 23, 2024

View reviewed changes

auth/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Apr 23, 2024

View reviewed changes

internal/groups/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Apr 23, 2024

View reviewed changes

things/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Apr 23, 2024

View reviewed changes

WashingtonKK force-pushed the MG-1987 branch 3 times, most recently from 50631ab to 9ab27ca Compare April 23, 2024 21:03

arvindh123 reviewed Apr 25, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

rodneyosodo previously approved these changes May 15, 2024

View reviewed changes

dborovcanin requested changes May 18, 2024

View reviewed changes

WashingtonKK dismissed rodneyosodo’s stale review via 9fb709b May 18, 2024 18:12

WashingtonKK added 20 commits May 18, 2024 21:14

Remove couple between invitations and user service

2b41524

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Update mocks

bad38cf

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> revert changes on invitations service Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

View basic info for entities

9837f51

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix testsg Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

refactor retrieve domain

8fca5b5

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix tests and add id to domain

76c7ace

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

feat(sdk): add api test cases for changes

4ea266f

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: use separate admin token in view client test

a5d6a5a

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: property based tests

9b06f5d

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: API tests

ad62e9f

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: prevent retrievebyID from returning same response

3a94b00

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: remove redundant error wrap

8cc1aef

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: return basic info when listing members

4688dc0

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: tests

7744d3e

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: tests

c373524

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

refactor service layer

4a0d783

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix ci

a602ee4

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: refactor code'

cdf0ff1

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: refactor code'

00953e5

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

WashingtonKK force-pushed the MG-1987 branch from 51c3c3e to 00953e5 Compare May 18, 2024 18:14

rodneyosodo approved these changes May 20, 2024

View reviewed changes

dborovcanin approved these changes May 20, 2024

View reviewed changes

dborovcanin merged commit e72e8a6 into absmach:main May 20, 2024
6 checks passed

dborovcanin pushed a commit that referenced this pull request May 20, 2024

MG-1987 - Enable entity endpoints to return basic info for non-admins (…

3e70fed

…#2168) Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

felixgateru mentioned this pull request May 22, 2024

Bug: New user to the platform sees all users #1976

Open

rodneyosodo mentioned this pull request May 28, 2024

MG-1955 - Bootstrap service is not synced to the latest changes of access control #2199

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MG-1987 - Enable Entity Endpoints to Return Basic Info for non-admins. #2168

MG-1987 - Enable Entity Endpoints to Return Basic Info for non-admins. #2168

WashingtonKK commented Apr 11, 2024 •

edited

arvindh123 commented Apr 18, 2024

arvindh123 left a comment •

edited

dborovcanin May 18, 2024

dborovcanin May 18, 2024

dborovcanin May 18, 2024

MG-1987 - Enable Entity Endpoints to Return Basic Info for non-admins. #2168

MG-1987 - Enable Entity Endpoints to Return Basic Info for non-admins. #2168

Conversation

WashingtonKK commented Apr 11, 2024 • edited

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

arvindh123 commented Apr 18, 2024

arvindh123 left a comment • edited

Choose a reason for hiding this comment

dborovcanin May 18, 2024

Choose a reason for hiding this comment

dborovcanin May 18, 2024

Choose a reason for hiding this comment

dborovcanin May 18, 2024

Choose a reason for hiding this comment

WashingtonKK commented Apr 11, 2024 •

edited

arvindh123 left a comment •

edited