MG-2053 : Structure API Endpoints Based on Entities #2195
+2,201
−794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
requested changes
Apr 23, 2024
WashingtonKK
force-pushed
the
MG-2053
branch
5 times, most recently
from
58e29a0
to
6f1aac9
Compare
WashingtonKK
force-pushed
the
MG-2053
branch
2 times, most recently
from
8a2578f
to
d1bb489
Compare
rodneyosodo
requested changes
Apr 30, 2024
rodneyosodo
requested changes
May 3, 2024
rodneyosodo
requested changes
May 7, 2024
WashingtonKK
force-pushed
the
MG-2053
branch
2 times, most recently
from
7815468
to
6b9cec8
Compare
rodneyosodo
requested changes
May 9, 2024
felixgateru
requested changes
May 23, 2024
It is already up to date @1998-felix |
rodneyosodo
requested changes
May 27, 2024
arvindh123
requested changes
Jun 5, 2024
There was a problem hiding this comment.
At present we have /things/thingID/channels to list channels
After this PR #2195 it will be like
/channels/things/thingID to list channels
which doesn't looks good and ideal
I have discussed this with @dborovcanin , He proposed like this /channels?thing=<id>
I agree with his proposal,
Already we are having /channels which is used for listing all channels,
/channels?thing=<id> can be used to listing channels of particular thing id.
/channels?user=<id> can be used to listing channels of particular user id.
and so on.
WashingtonKK
force-pushed
the
MG-2053
branch
2 times, most recently
from
f753a58
to
21dc1f6
Compare
arvindh123
requested changes
Jun 10, 2024
WashingtonKK
force-pushed
the
MG-2053
branch
2 times, most recently
from
50a7944
to
4f9abae
Compare
felixgateru
reviewed
Jun 11, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update api docs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update sdk Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update sdk Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor: api docs and sdk Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: api docs' Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update sdk and docs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update groups sdk and docs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> feeat(groups): add groups sdk tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> feat(sdk): tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: sdk tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> feat(users): add api tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix(api tests): add missing tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: users api tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix domain endpoint tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update sdk Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> tmp Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the naming and structuring of API endpoints.
What does this do?
This restructures API endpoints so that they are named based on entities such as groups, channels, users, things etc.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No, I have not included tests.
Did you document any new/modified feature?
Yes, I have updated the documentation for the new feature.
Notes