MG-2214 - Add LTREE Path to Groups #2223
Open
+267
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WashingtonKK
force-pushed
the
MG-2214
branch
2 times, most recently
from
c8c66bc
to
603cf33
Compare
rodneyosodo
requested changes
May 24, 2024
pkg/groups/groups.go
Outdated
| @@ -52,6 +52,7 @@ type MembersPage struct { | |||
| // of Groups that belong to the page. | |||
| type Page struct { | |||
| PageMeta | |||
| Type string | |||
| } | ||
| if gm.ID == "" { | ||
| q = `SELECT DISTINCT g.id, g.domain_id, COALESCE(g.parent_id, '') AS parent_id, g.name, g.description, | ||
| g.metadata, g.created_at, g.updated_at, g.updated_by, g.status FROM groups g` | ||
| g.metadata, g.created_at, g.updated_at, g.updated_by, g.status, nlevel(path) as level, g.path FROM groups g` | ||
| query = buildQuery(gm, "WHERE") |
There was a problem hiding this comment.
Add the WHERE and AND clauses in buildquery
There was a problem hiding this comment.
They are added in buildquery @rodneyosodo, I added WHERE as a parameter since at times we need to build the query with a WHERE clause and at times we need to append more queries using AND.
internal/groups/postgres/groups.go
Outdated
| return query | ||
| } | ||
| path = parent.Path + "." + g.ID | ||
| if len(strings.Split(path, ".")) > 20 { |
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> feat(groups): ffetch groups using ltree Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix(groups): remove lquery Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> feat(groups): add index Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix(groups): handle empty response body Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor groups for test Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor: ltree in groups Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds LTREE to groups.
What does this do?
This adds ltree to groups
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
Yes, I have updated the documentation for the new feature.
Notes
Signed-off-by: WashingtonKK washingtonkigan@gmail.com