MG-2201 - Add Policy to Fail Role Update if User Not on Platform #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffMboya
force-pushed
the
MG-2201
branch
11 times, most recently
from
1768f0a
to
3bf4593
Compare
rodneyosodo
requested changes
May 17, 2024
There was a problem hiding this comment.
Since we check if the user is SuperAdmin first before updating the role, then they are certainly in the platform @arvindh123 what do you think?
arvindh123
approved these changes
May 20, 2024
arvindh123
reviewed
May 20, 2024
There was a problem hiding this comment.
Since we check if the user is SuperAdmin first before updating the role, then they are certainly in the platform @arvindh123 what do you think?
@rodneyosodo
In previous part of the code, we are checking the Request User is SuperAdmin or Normal User.
we are not checking the role change user ID .
It is like super admin can make other user as super admin or normal user
In role change API endpoint, SuperAdmin will be sending the user id of the other user to change the role.
So we should check the user id given by super admin in request , is exists in platform or not.
arvindh123
requested changes
May 20, 2024
JeffMboya
force-pushed
the
MG-2201
branch
3 times, most recently
from
6c58f06
to
d519516
Compare
arvindh123
previously approved these changes
May 21, 2024
rodneyosodo
requested changes
May 22, 2024
JeffMboya
changed the title
rodneyosodo
requested changes
May 23, 2024
WashingtonKK
requested changes
May 23, 2024
JeffMboya
force-pushed
the
MG-2201
branch
2 times, most recently
from
3137712
to
8c077be
Compare
arvindh123
approved these changes
May 24, 2024
rodneyosodo
approved these changes
May 24, 2024
rodneyosodo
previously approved these changes
May 24, 2024
arvindh123
requested changes
May 30, 2024
arvindh123
previously approved these changes
May 30, 2024
felixgateru
previously approved these changes
May 31, 2024
rodneyosodo
previously approved these changes
May 31, 2024
dborovcanin
reviewed
Jun 5, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor:Add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor:Add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor:Add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor:Add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor:Add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor:Add memberRelation policy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: Revert changes in grpcServer struct Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: Revert changes in grpcServer struct Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: Fix authorization error in updateClientPolicy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: Fix authorization error in updateClientPolicy Signed-off-by: JeffMboya <jangina.mboya@gmail.com> refactor: Fix authorization error in updateClientPolicy Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> fix: failing tests Signed-off-by: JeffMboya <jangina.mboya@gmail.com> fix: failing tests Signed-off-by: JeffMboya <jangina.mboya@gmail.com> fix: failing tests Signed-off-by: JeffMboya <jangina.mboya@gmail.com> fix: failing tests Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
dismissed stale reviews from rodneyosodo, felixgateru, and arvindh123
via
60f460d
arvindh123
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: client check check in policy layer when updating client role.
What does this do?
This PR modifies the update client role functionality to check for client existence in the policy layer (spiceDB) instead of the repo layer. This prevents the system from adding a policy for a non-existent user and then having to roll it back.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No