[WIP] Custom Reports: Include current

[carkom]

Testing an option to add/remove current interval to "live" ranges.

I still need to add a migration so that it can be saved as part of the report. Holding off on that right now as I don't want it to mess up anyone's budget file.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	0c2d4e0
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6630a8ed72d0840008c71265
😎 Deploy Preview	https://deploy-preview-2684.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.67 MB → 4.67 MB (+1.42 kB)	+0.03%

Changeset

File	Δ	Size
src/components/reports/getLiveRange.ts	📈 +94 B (+9.92%)	948 B → 1.02 kB
src/components/reports/ReportSidebar.jsx	📈 +888 B (+5.42%)	15.99 kB → 16.85 kB
home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/reports.ts	📈 +57 B (+4.82%)	1.16 kB → 1.21 kB
src/components/reports/reports/CustomReport.jsx	📈 +356 B (+1.78%)	19.58 kB → 19.92 kB
src/components/reports/reports/GetCardData.tsx	📈 +31 B (+0.72%)	4.2 kB → 4.23 kB
src/components/reports/ReportOptions.ts	📈 +26 B (+0.43%)	5.91 kB → 5.93 kB
src/components/reports/reportRanges.ts	📉 -1 B (-0.04%)	2.75 kB → 2.74 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.2 MB → 1.2 MB (+1.36 kB)	+0.11%
static/js/index.js	2.99 MB → 2.99 MB (+57 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	59.68 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	20.41 kB	0%
static/js/wide.js	263.53 kB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

[Teprifer]

The 'current interval' controlled by the option is 'month' rather than what is defined by the interval option? if so I'd suggest renaming it to Include current month for clarity. e.g. interval is weekly, with a live range of last 3 months, this option toggles the 4 weeks starting this month.
How it is now vs making it go by the interval option both makes sense to me (as the budgeting is monthly).

Noticed option is disabled when using a static range(makes obvious sense). Were you thinking to disable it for the interval + live ranges that it doesn't make sense for, or not worry about that?

[carkom]

The 'current interval' controlled by the option is 'month' rather than what is defined by the interval option? if so I'd suggest renaming it to Include current month for clarity. e.g. interval is weekly, with a live range of last 3 months, this option toggles the 4 weeks starting this month. How it is now vs making it go by the interval option both makes sense to me (as the budgeting is monthly).

Noticed option is disabled when using a static range(makes obvious sense). Were you thinking to disable it for the interval + live ranges that it doesn't make sense for, or not worry about that?

It's not always monthly. It's based on the range interval. Example: choosing "Last week" and Interval = daily. The toggle would give you all the days from this week as well.

If we changed it to match the interval instead and you chose "last month" and interval = weekly. You'd see all 4 weeks of March. Select the new toggle and you'd get the 4th week of April - the first three weeks would be missing. Not sure that makes sense to ever have a view like that. Also, it makes the code needlessly complicated.

I see your point with labeling, because it's not actually "current interval". I've changed the wording to follow the "range" selection. So it says "Include current month" when a monthly range is chosen and "Include current week" when a weekly range is chosen.

[Teprifer]

Ah! I see where I was getting confused, thanks. :) (there was an extra layer of misunderstanding on my part too)