Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Reports: TS strict changes #3 #2728

Merged
merged 12 commits into from May 16, 2024
Merged

Conversation

carkom
Copy link
Contributor

@carkom carkom commented May 8, 2024

Making files in custom reports to comply with TS strict - stage 3

@github-actions github-actions bot changed the title Custom Reports: TS strict changes #3 [WIP] Custom Reports: TS strict changes #3 May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0722eeb
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6643b78d803fad0008a91627
😎 Deploy Preview https://deploy-preview-2728.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.72 MB → 4.72 MB (+653 B) +0.01%
Changeset
File Δ Size
src/components/reports/ChooseGraph.tsx 📈 +266 B (+6.65%) 3.91 kB → 4.17 kB
src/components/reports/spreadsheets/grouped-spreadsheet.ts 📈 +158 B (+4.19%) 3.69 kB → 3.84 kB
src/components/reports/graphs/AreaGraph.tsx 📈 +223 B (+2.71%) 8.04 kB → 8.26 kB
src/components/reports/spreadsheets/recalculate.ts 📈 +6 B (+0.41%) 1.41 kB → 1.42 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.23 MB → 1.23 MB (+653 B) +0.05%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.81 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.54 kB 0%
static/js/wide.js 262.4 kB 0%
static/js/index.js 3 MB 0%

Copy link
Contributor

github-actions bot commented May 8, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@carkom carkom changed the title [WIP] Custom Reports: TS strict changes #3 Custom Reports: TS strict changes #3 May 14, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 14, 2024
@carkom carkom requested review from MatissJanis and twk3 May 14, 2024 19:12
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carkom one suggestion. Otherwise looks good!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 16, 2024
@carkom carkom merged commit 1fc7c99 into actualbudget:master May 16, 2024
19 checks passed
@carkom carkom deleted the CR-strict3 branch May 16, 2024 21:54
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants