Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cover image to rss #1370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add cover image to rss #1370

wants to merge 1 commit into from

Conversation

vindex10
Copy link

@vindex10 vindex10 commented Dec 29, 2023 •
edited

What does this PR change? What problem does it solve?

Was the change discussed in an issue or in the Discussions before?
Related issue: #891

Include cover image into rss feed. Example in the screenshot:

image

This PR also restores the removed xmlns: xmlns:content="http://purl.org/rss/1.0/modules/content/"
It was removed by 00488d0 , which broke the use of the content:encoding tag.

I chose to keep it as a single change, since the xmlns was an accidental regression, and this PR itself is small.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • (restored the CDN link which was used before) This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vindex10 vindex10 mentioned this pull request Jan 3, 2024
Open
@adityatelange adityatelange linked an issue Jan 7, 2024 that may be closed by this pull request
🖼 Cover images in RSS feeds? #891
Open
@vindex10 vindex10 mentioned this pull request Jan 26, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vindex10
Copy link
Author

vindex10 commented Feb 8, 2024

@adityatelange now it is cleaner, after #1411 and I rebased to resolve the conflicts.

hugocf added a commit to hugocf/ferreira.cc that referenced this pull request Mar 14, 2024
@hugocf
Show cover images in RSS feed
3451664 
Based on PR:

- [add cover image to rss by vindex10 · Pull Request #1370 · adityatelange/hugo-PaperMod](adityatelange/hugo-PaperMod#1370)
sckott added a commit to sckott/recology that referenced this pull request Mar 18, 2024
@sckott
use adityatelange/hugo-PaperMod#1370 pull request
6e86ab0
hugocf added a commit to hugocf/ferreira.cc that referenced this pull request Mar 29, 2024
@hugocf
PaperMod: Show cover images in RSS feed using enclosures
8497e83 
Adapted from:

- https://stackoverflow.com/a/52178661/1380781
- adityatelange/hugo-PaperMod#1370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🖼 Cover images in RSS feeds?
1 participant
@vindex10