Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace thumbnailUrl with logo #1488

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

xuhdev
Copy link

@xuhdev xuhdev commented Apr 11, 2024

thumbnailUrl is not part of Organization: https://schema.org/Organization

What does this PR change? What problem does it solve?

The default publisher type, as defined by this theme, is "Organization". However, based on its definition at https://schema.org/Organization, thumbnail is not part of "Organization".

This PR addresses this issue by replacing thumbnailUrl with logo.

Alternatively, if the maintainer feels like it, we can use image as well. The advantage of image is that it is also defined as part of Person: https://schema.org/Person

Was the change discussed in an issue or in the Discussions before?

No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

sonarcloud bot commented Apr 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant