Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: esm build source mapping url replacement #6368

Merged
merged 2 commits into from
May 16, 2024
Merged

fix: esm build source mapping url replacement #6368

merged 2 commits into from
May 16, 2024

Conversation

oedotme
Copy link
Contributor

@oedotme oedotme commented May 12, 2024 •
edited by snowystinger

Closes #6367
Closes #6355

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@oedotme oedotme mentioned this pull request May 12, 2024
Closed
@snowystinger
Copy link
Member

Thanks for the PR! This change looks fine. You'll need to sign the CLA though to get the PR to pass https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement
You may need to close and reopen the PR to get it to appear correct. Then we can approve this and get it in.

@oedotme oedotme closed this May 13, 2024
@oedotme oedotme reopened this May 13, 2024
@oedotme
Copy link
Contributor Author

oedotme commented May 13, 2024

@snowystinger Thanks for sharing this! The PR is now ready.

@jer3m01 jer3m01 mentioned this pull request May 13, 2024
Closed
@frenicohansen frenicohansen mentioned this pull request May 13, 2024
Closed
2 tasks
LFDanLu
LFDanLu approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified locally that the built files points to the proper .module.js.map file now. Also verified via a local test app that the aforementioned module warnings no longer appear (they were coming up in the terminal during the local build previously)

@LFDanLu LFDanLu merged commit d7f78e8 into adobe:main May 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@oedotme @snowystinger @LFDanLu