Yarn 4 #6215
Yarn 4 #6215
Conversation
|
Build successful! 🎉 |
# Conflicts: # yarn.lock
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
1 similar comment
1 similar comment
| @@ -0,0 +1,106 @@ | |||
| # | |||
There was a problem hiding this comment.
included so we could do anonymous publishing to verdaccio
| @@ -18,12 +18,10 @@ function cleanup { | |||
| then | |||
| lsof -ti tcp:4000 | xargs kill | |||
| # Clean up generated dists if run locally | |||
| shopt -s globstar extglob | |||
There was a problem hiding this comment.
only intel macs need this, m macs will throw on this and crash, failing to cleanup. now that the majority of the common users of this script are on m macs, I'm removing it
| rm -rf packages/**/dist | ||
| rm -rf storage/ ~/.config/verdaccio/storage/ $output | ||
| if [ "$commit_to_revert" != "HEAD" ]; | ||
| then | ||
| git tag -d $(git tag -l) |
There was a problem hiding this comment.
lerna default tagged everything and created a commit, using yarn, we can simplify and not create tags and not create extra commits
| # build prod docs with a public url of /reactspectrum/COMMIT_HASH_BEFORE_PUBLISH/verdaccio/docs | ||
| PUBLIC_URL=/reactspectrum/`git rev-parse HEAD~1`/verdaccio/docs make website-production | ||
| PUBLIC_URL=/reactspectrum/`git rev-parse HEAD~0`/verdaccio/docs make website-production |
There was a problem hiding this comment.
this is the simplification based on lerna used to create an extra commit with tags, now we don't do that, so we can just use the current commit
|
## API Changes
unknown top level export { type: 'any' } |
Closes
Comments inline below
I've left a couple peer dependency resolutions for later because they'll be solved by some other PRs we have.
I still want to replace the rest of patch-package, but that can be done in followup
I've managed to remove a total of 99 unique dependencies, a good chunk of that is lerna related.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: