Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalized/NumberParser: fix TS5.5 build errors #6329

Merged
merged 2 commits into from
May 16, 2024

Conversation

Renegade334
Copy link
Contributor

This small change pre-emptively addresses build errors that will appear under TypeScript 5.5, caused by changes relating to Intl.NumberFormat in microsoft/TypeScript#56902.

Unit tests are unaffected.

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. We do the same ?? 0 up above and they should always be defined
Thanks for the PR!

@LFDanLu LFDanLu merged commit e16aa4d into adobe:main May 16, 2024
26 checks passed
@Renegade334 Renegade334 deleted the numberformat-opts branch May 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants