Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix synthetic links not using useHref #6346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix synthetic links not using useHref #6346

wants to merge 1 commit into from

Conversation

joshuajaco
Copy link
Contributor

@joshuajaco joshuajaco commented May 8, 2024 •
edited

Closes #6347

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@joshuajaco joshuajaco force-pushed the fix-synthetic-links-with-basepath branch 2 times, most recently from fba1ec8 to 33ca102 Compare May 8, 2024 14:18
@joshuajaco joshuajaco marked this pull request as ready for review May 8, 2024 14:31
@joshuajaco joshuajaco force-pushed the fix-synthetic-links-with-basepath branch 2 times, most recently from 9fc618c to c0a5c54 Compare May 10, 2024 09:36
@joshuajaco joshuajaco force-pushed the fix-synthetic-links-with-basepath branch from c0a5c54 to 75ab16e Compare May 10, 2024 09:38
@MerryOscar MerryOscar mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useHref passed to RouterProvider not respected for synthetic links
1 participant
@joshuajaco