Fix default color value in ColorPicker #6364
Open
+48
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did do this on purpose. In Spectrum, we have a specific state for no value that gets shown. RAC users could also implement something like that with the render props. Open to discussing the default but just thought I'd mention. |
|
@devongovett Maybe we can differentiate |
LFDanLu
reviewed
May 16, 2024
| @@ -15,13 +15,13 @@ export interface ColorPickerState { | |||
|
|
|||
| export function useColorPickerState(props: ColorPickerProps): ColorPickerState { | |||
| let value = useColor(props.value); | |||
| let defaultValue = useColor(props.defaultValue || '#0000')!; | |||
| let defaultValue = useColor(props.defaultValue || '#000000')!; | |||
| let [color, setColor] = useControlledState(value || undefined, defaultValue, props.onChange); | |||
|
|
|||
| return { | |||
| color, | |||
| setColor(color) { | |||
There was a problem hiding this comment.
- add if check for null to early return in here
- update useColorSwatch so that color is required
- update docs (RSP/RAC/hooks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6363
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: