Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @swc/helpers in@react-stately/flags to match other packages #6379

Merged
merged 4 commits into from
May 20, 2024

Conversation

wojtekmaj
Copy link
Contributor

Closes #6378

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Build the package
  • Examine built source files and confirm there are no @swc/helpers imports in neither of the outputted files

🧢 Your Project:

wojtekmaj and others added 2 commits May 14, 2024 12:10
Meet requirement for having a dep on swc helpers
@snowystinger
Copy link
Member

Thanks for the PR, this should just be updated to the same range as all our other packages. There's no easy way to tell if we need swc/helpers for a particular package, so it's a dependency of all of them. Whether or not the dep is actually needed can change based on updates parcel/swc/browserslist/etc

@wojtekmaj wojtekmaj changed the title Remove @swc/helpers dependency from @react-stately/flags Bump @swc/helpers in@react-stately/flags to match other packages May 15, 2024
@LFDanLu LFDanLu merged commit 43e54d1 into adobe:main May 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@react-stately/flags stuck on old @swc/helpers?
4 participants