Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosine similarity methods #1337

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

corbanvilla
Copy link
Contributor

Added cosine similarity face-recognition methods to api.py along with unit testing.

I did a bunch of facial recognition for a school project and I found that for our use-case, cosine similarity was often more accurate and better at finding matches than euclidean distance so I added a couple methods that implement the formula.

@rememberlenny
Copy link

Looks good! Thank you!

@adilsheraz
Copy link

Nice

@emmywizzy4jah
Copy link

Please what about if a person captured by webcam is putting on a face mask but his/her image in my list is not putting on face mask. Will it recognize it?

@corbanvilla
Copy link
Contributor Author

@parthematics agreed and fixed!

@corbanvilla
Copy link
Contributor Author

@emmywizzy4jah there's too many factors to say for sure, it will depend on the quality of both sources, the mask positioning and the model's ability to extract features to name a few... you may or may not see better performance, please feel free to try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants