Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run.ts #1346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update run.ts #1346

wants to merge 1 commit into from

Conversation

liushmh
Copy link

@liushmh liushmh commented Jun 27, 2021

if save to db failed, finished should stay false, otherwise, the job could never be completed.

if save to db failed, finished should stay false, otherwise, the job could never be completed.
@liushmh
Copy link
Author

liushmh commented Jun 27, 2021

Be more specific:
if save is failed, the status of 'old' job is 'finished', but field 'lastFinishedAt' is not updated into database,
so is-running.ts will always return true.
In this case, the real 'new' job will never start.

@harisvsulaiman
Copy link
Member

@liushmh Please write a test case for the problem you are trying to solve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants