Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few updates on the README.md instructions #1530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luizcarlos1405
Copy link

@luizcarlos1405 luizcarlos1405 commented Apr 27, 2023

  1. The current docs do not include a shouldSaveResult or setShouldSaveResult and they do not work on V6.x.

image

  1. Calling agenda.database returns a Promise and not an Agenda instance, so the order of the configuration calls in the example was wrong.

The current docs do not include a saveResults or setSaveResults and they do not work on V6.x
The instructions didn't take into account that `agenda.database` actually returns a `Promise` and not an `Agenda` instance.
@luizcarlos1405 luizcarlos1405 changed the title Remove saveResults examples from README.md A few updates on the README.md instructions Apr 28, 2023
@luizcarlos1405
Copy link
Author

Oh, it seems this repo doesn't have version 6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant