Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed this={} in processDbResult #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Solpatium
Copy link

this in processDbResult in save-job.js file is always {}, but it should be bound to agenda instance. Because of this a job is never run immediately, which is not a big issue, but it raises an error, for example, after Babel transpilation, because this is undefined.

Fixing it breaks the tests, because

processJobs.call(this, job);

might actually run and it doesn't take _jobsToLock into consideration. This is why a check for this was added.

@Beretta1979
Copy link

Could this be reviewed , need this fix

@mkaput
Copy link

mkaput commented Sep 24, 2019

rebased onto latest master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants