Pause and Resume implementation wrapper using already exisiting functions

[mur2zab]

Couldn't find pause and resume functionality in the existing library. Tried to help using the existing functions. Comments are appreciated. First contribution to Open Source.

[AhmadIbrahiim]

It seems to be perfect if we can add pause and resume to AGENDA!

[simison]

pause('1 day') could be an interesting feature as well (using human-interval. No need in this PR, just noting for future.

[simison]

Should pause the job test seems to be failing at the moment. @mur2zab could you have a look? Thanks!

Could you also add this to documentation (in README.md)

[simison]

Could you change this to @name @name Job#pause?

[simison]

Could you change this to @name @name Job#resume?

[simison]

How would we resume jobs with an interval set? Should we use computeFromInterval?

agenda/lib/job/compute-next-run-at.js

Line 34 in b71d3ea

const computeFromInterval = () => {

[simison]

I'd like to see tests that cover different types of jobs: requrring ones, one-off ones etc. What do you think?

[mur2zab]

Should pause the job test seems to be failing at the moment. @mur2zab could you have a look? Thanks!

Could you also add this to documentation (in README.md)

Sure will look into the comments. Thanks for reviewing @simison

[pdfowler]

Proposing we close this as pause/resume implementation is near identical to the existing enable/disable functionality.

From PR in the pause.js file

// Pause
module.exports = function() {
   this.attrs.disabled = true;
   return this.save();
 };

From existing disable file

// Disable
export const disable = function (this: Job): Job {
  this.attrs.disabled = true;
  return this;
};

From a DX perspective, I often got tripped up with which job methods called save internally and which were chainable. I have a strong preference for chainable job methods, and leaving it to the user to call save explicitly.