-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace setuptools with Poetry #975
base: master
Are you sure you want to change the base?
Conversation
- poetry manages all aspects of project metadata and dependencies in pyproject.toml - Pipfile is obsolete - setup.py is obsolete - project might only support python >=3.7,<4.0 now? - tests will not run in python 3.6.x - contributions require python 3.8
Poetry's dependency resolution will ensure that all packages are compatible.
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
- Coverage 84.98% 84.81% -0.18%
==========================================
Files 50 50
Lines 4529 4464 -65
==========================================
- Hits 3849 3786 -63
+ Misses 680 678 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request fixes 8 alerts when merging ebc5ce5 into 551343c - view on LGTM.com fixed alerts:
|
.github/workflows/python-package.yml
Outdated
pipenv sync --dev | ||
pipenv check || true | ||
pipenv graph | ||
curl -sSL https://install.python-poetry.org/ | python - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also install poetry using pip on the line below 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in lafrenierejm@caf724d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm a big fan of Poetry, but it is up to the maintainer to decide since it also impacts the release process.
@thehesiod Any opinions on these changes? |
@lafrenierejm cool! we finally bumped, could you merge/re-base. Also how does this solution guarantee that each PR has a correct boto3/awscli match to the botocore version? Wouldn't you need to re-lock each time? I would think we shouldn't have a lockfile checked in in that case. |
If we are to change tools, maybe we should look at tools that support PEP 621. There are notable examples in the "PEP 517 ecosystem", like:
|
cool thanks for the tips, worthy conversation |
So the match is enforced via the versions provided in The After trying to contribute a PR I think switching from |
Description of Change
Intended to obsolete #835. This PR fixes tests and CI that are (as best as I can tell as of this writing) broken in #835.
Assumptions
Compared to the existing build system using setuptools and Pipfile, Poetry makes it easier to
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions