-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Integrate Hypothesis in tests #860
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 99.33% 99.48% +0.14%
==========================================
Files 17 4 -13
Lines 3315 772 -2543
Branches 323 0 -323
==========================================
- Hits 3293 768 -2525
+ Misses 22 4 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e6af87c
to
23f4ed0
Compare
@mjpieters I started looking into using Hypothesis during PyCon (the maintainer helped me start). |
I was going to look into that since I found this PR! It does look like |
Actually, no this is not a bug in Yarl; it is a bug in your Hypothesis tests. test_quote_unquote_parameter(
quoter=yarl._quoting_c._Quoter,
unquoter=yarl._quoting_c._Unquoter,
text_input='0',
safe='',
unsafe='0', # <--- 0 is unsafe
protected='',
qs=False,
requote=False,
) With Either not tell Hypothesis to provide input to |
@mjpieters yeah, I never used these and wasn't sure about the semantics which is why I asked you. My objective is to make the foundation for adding more Hypothesis testing in the future and so the contributors could look at the examples... |
6d4483d
to
b68147b
Compare
958a7d4
to
19b85a6
Compare
98412df
to
37a9f48
Compare
d0a3aff
to
c3036c3
Compare
@mjpieters do you have ideas on how to best get this integrated finally? What extra constraints do we need in these tests? |
914bd16
to
f0564f9
Compare
f0564f9
to
31b4b37
Compare
What do these changes do?
$sbj
Are there changes in behavior for the user?
Nah
Related issue number
Nope
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.