Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Showkase to newer versions of Compose + Kotlin + KSP #384

Merged
merged 5 commits into from
May 25, 2024
Merged

Upgraded Showkase to newer versions of Compose + Kotlin + KSP #384

merged 5 commits into from
May 25, 2024

Conversation

vinaygaba
Copy link
Collaborator

@vinaygaba vinaygaba commented May 21, 2024 •
edited

Fixes #382, #345 & #343

  • Upgrades Showkase to newer versions of Compose, Kotlin, KSP
  • Updates the screenshots as newer versions require them to be updated
  • Swap out the Kotlin Compile Testing fork as it tracks the Kotlin releases better - https://github.com/ZacSweers/kotlin-compile-testing
  • Updated the BaseProcessorTest to account for the forked version of the Kotlin Compile Testing library

@airbnb/showkase-maintainers

skylerreimer
skylerreimer reviewed May 21, 2024
View reviewed changes
build.gradle
'compose' : '1.4.2',
'composeCompiler' : '1.4.2',
'composeActivity' : '1.5.1',
'compose' : '1.6.7',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨✨✨

Thank you!!!

This was linked to issues May 21, 2024
Incorrect generate ShowcaseBrowser color with kotlin 1.9 #345
Closed
PreviewParameters don't work with Kotlin 1.9 #343
Closed
@vinaygaba vinaygaba merged commit b69d26a into master May 25, 2024
6 checks passed
@vinaygaba vinaygaba mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylerreimer skylerreimer skylerreimer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vinaygaba @skylerreimer