Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fetcher] Print exceptions prior to reporting for metrics #579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikhilsimha
Copy link
Contributor

Summary

We now expose exceptionSampleRate via API - default is 0.1 - one among every 10 exceptions will be logged.

Why / Goal

Currently we don't log exceptions at all, which makes debugging difficult. This will make it so that by default we print a fraction of exceptions.

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@hzding621 @qiyang0221

@qiyang0221
Copy link

Will this guarantee at least one exception per each fetching?

@nikhilsimha
Copy link
Contributor Author

Will this guarantee at least one exception per each fetching?

It doesn't, but you can set the rate to 1 if you want to guarantee.

@qiyang0221
Copy link

Will this guarantee at least one exception per each fetching?

It doesn't, but you can set the rate to 1 if you want to guarantee.

This might not ideal cuz we need at least one log message from AFP client to identify the root cause in a short time.

@nikhilsimha
Copy link
Contributor Author

Will this guarantee at least one exception per each fetching?

It doesn't, but you can set the rate to 1 if you want to guarantee.

This might not ideal cuz we need at least one log message from AFP client to identify the root cause in a short time.

You can adjust the exception rate on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants