[Fetcher] Print exceptions prior to reporting for metrics #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now expose exceptionSampleRate via API - default is 0.1 - one among every 10 exceptions will be logged.
Why / Goal
Currently we don't log exceptions at all, which makes debugging difficult. This will make it so that by default we print a fraction of exceptions.
Test Plan
Checklist
Reviewers
@hzding621 @qiyang0221