[WIP] Embedding API #584
Open
[WIP] Embedding API #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsimha
commented
Oct 17, 2023
| 1: optional Storage storage | ||
| 2: optional DataFormat format | ||
| 3: optional string path | ||
| 4: optional string jsonParams |
There was a problem hiding this comment.
Support new partitions landing into s3
nikhilsimha
commented
Oct 17, 2023
| * We can eventually fine-tune a general queryParsing model based on the schema of the index. | ||
| * We expect the output of this model to be list of filters needed by the index | ||
| **/ | ||
| 7: optional ModelSpec queryParsingModel |
There was a problem hiding this comment.
Move this to catalog level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP
Checklist
Reviewers
@hzding621