Fix base64 image asset not fit container's size #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
reviewed
May 11, 2024
| @@ -107,6 +107,7 @@ public void setDelegate(@Nullable ImageAssetDelegate assetDelegate) { | |||
| return null; | |||
| } | |||
| bitmap = BitmapFactory.decodeByteArray(data, 0, data.length, opts); | |||
| bitmap = Utils.resizeBitmapIfNeeded(bitmap, asset.getWidth(), asset.getHeight()); | |||
There was a problem hiding this comment.
Could you store the bitmap on the line above to a local variable?
There was a problem hiding this comment.
@gpeal I updated, please check
gpeal
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I am encountering a similar issue to #1200, but in the case where the asset is a base64 image, it has not been fixed yet.