Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: add auto_merge as an internal package #38020

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented May 7, 2024

Relates to https://github.com/airbytehq/airbyte-internal-issues/issues/7554
This PR will add CI steps to check the health of the auto_merge package.
Only type checks and linting will run ATM according to the content of the pyproject.toml file of the auto_merge package.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:56am

Copy link
Contributor Author

alafanechere commented May 7, 2024

@alafanechere alafanechere marked this pull request as ready for review May 7, 2024 11:58
@alafanechere alafanechere requested a review from a team as a code owner May 7, 2024 11:58
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but please:

  • Fix mypy type checks
  • Prettier the readme
  • Suggestion with PR link

@@ -745,6 +745,7 @@ E.G.: running Poe tasks on the modified internal packages of the current branch:

| Version | PR | Description |
|---------| ---------------------------------------------------------- |------------------------------------------------------------------------------------------------------------------------------|
| 4.12.7 | [#TBD](https://github.com/airbytehq/airbyte/pull/TBD) | Add `auto_merge` as an internal package to test. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 4.12.7 | [#TBD](https://github.com/airbytehq/airbyte/pull/TBD) | Add `auto_merge` as an internal package to test. |
| 4.12.7 | [#38020](https://github.com/airbytehq/airbyte/pull/38020) | Add `auto_merge` as an internal package to test. |

@alafanechere alafanechere force-pushed the augustin/05-06-create_auto_merge_package branch from 4f8ed1b to da21c54 Compare May 13, 2024 09:55
@alafanechere alafanechere force-pushed the augustin/05-07-airbyte-ci_add_auto_merge_as_an_internal_package branch from 37613ba to 4e1c577 Compare May 13, 2024 09:56
@alafanechere alafanechere merged commit 51c739d into augustin/05-06-create_auto_merge_package May 13, 2024
35 of 48 checks passed
@alafanechere alafanechere deleted the augustin/05-07-airbyte-ci_add_auto_merge_as_an_internal_package branch May 13, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants