fix: remove invalid list RBAC for pod/log resource
#621
Conversation
Removing invalid verb: list, from the pods/log resource in airflow role. List is not a valid verb for pods/log as per the kubernetes api spec. It appears that the only valid verb for pods/log is get, see: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#get-read-log-of-the-specified-pod Signed-off-by: John Arnesen <arnesenfamily@gmail.com>
|
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
thesuperzapper
changed the title
list RBAC for pod/log resource
|
@arnesenfamily thanks for the PR, it looks great! I have added this to the |
thesuperzapper
moved this from Unsorted
to PR | Ready to Merge
in Issue Triage and PR Tracking
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
removed
the
status/ready-to-merge
There was a problem hiding this comment.
@arnesenfamily sorry for this, but I can see the DCO bot is complaining that you signed off the commit with the wrong name: Expected "arnesenfamily [arnesenfamily@users.noreply.github.com](mailto:arnesenfamily@users.noreply.github.com)", but got "John Arnesen [arnesenfamily@gmail.com](mailto:arnesenfamily@gmail.com)".
Additionally, the semantic PR bot is complaining that your commit message needs to be semantic, please rename it to: fix: remove invalid `list` RBAC for `pod/log` resource
Can you please force push and fix this?
thesuperzapper
moved this from PR | Needs Review
to PR | Waiting for Changes
in Issue Triage and PR Tracking
What issues does your PR fix?
What does your PR do?
listfrom thepods/logresource of the airflow RBAC Role. This is becauselistis not a valid verb forpods/logas per the Kubernetes API spec, it appears that the only valid verb forpods/logisget.