Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add values for priorityClassName #648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pkalemba
Copy link

@pkalemba pkalemba commented Sep 20, 2022

What does your PR do?

Adds priorityClassName to pods

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Paweł Kalemba <pawel.kalemba@getresponse.com>
@pkalemba
Copy link
Author

@thesuperzapper can You look at it please?

@stale
Copy link

stale bot commented Dec 4, 2022

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Dec 4, 2022
@pkalemba
Copy link
Author

pkalemba commented Dec 9, 2022

Can someone look at it ?

@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Dec 9, 2022
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkalemba you are amazing! Thanks for this PR!

I have left a small number of comments that need to be fixed, but otherwise it looks good for the next release.

@@ -1,7 +1,7 @@
apiVersion: v2
description: Airflow Helm Chart (User Community) - the standard way to deploy Apache Airflow on Kubernetes with Helm
name: airflow
version: 8.6.1
version: 8.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this, as it will trigger a release of the chart if merged.

Comment on lines +200 to +201
## default priorityClassName for airflow Pods (is overridden by pod-specific values)
defaultPriorityClassName: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things consistent let's use the same formatting as the other docstrings:

  ## default priorityClassName for airflow Pods (is overridden by pod-specific values)
  ## - docs for priorityClassName:
  ##   https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
  ##
  defaultPriorityClassName: ""

@@ -412,6 +415,10 @@ airflow:
##
securityContext: {}

## the priorityClassName for the db-migrations Pods
##
priorityClassName: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link for people who don't know what priorityClassName is:

  ## the priorityClassName for the db-migrations Pods
  ## - docs for priorityClassName:
  ##   https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
  ##
  priorityClassName: ""

NOTE: we will also need to add it to all the other priorityClassName docstrings in this values file

@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Feb 7, 2023
@thesuperzapper thesuperzapper changed the title feat(priorityClassName): Allow users to set priorityClassName add values for priorityClassName Feb 7, 2023
@thesuperzapper thesuperzapper added this to the airflow-8.7.0 milestone Feb 7, 2023
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Waiting for Changes in Issue Triage and PR Tracking Feb 7, 2023
@thesuperzapper thesuperzapper changed the title add values for priorityClassName feat: add values for priorityClassName May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issue Triage and PR Tracking
PR | Waiting for Changes
Development

Successfully merging this pull request may close these issues.

None yet

2 participants