New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add values for priorityClassName
#648
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Paweł Kalemba <pawel.kalemba@getresponse.com>
@thesuperzapper can You look at it please? |
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
Can someone look at it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkalemba you are amazing! Thanks for this PR!
I have left a small number of comments that need to be fixed, but otherwise it looks good for the next release.
@@ -1,7 +1,7 @@ | |||
apiVersion: v2 | |||
description: Airflow Helm Chart (User Community) - the standard way to deploy Apache Airflow on Kubernetes with Helm | |||
name: airflow | |||
version: 8.6.1 | |||
version: 8.6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change this, as it will trigger a release of the chart if merged.
## default priorityClassName for airflow Pods (is overridden by pod-specific values) | ||
defaultPriorityClassName: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things consistent let's use the same formatting as the other docstrings:
## default priorityClassName for airflow Pods (is overridden by pod-specific values)
## - docs for priorityClassName:
## https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
##
defaultPriorityClassName: ""
@@ -412,6 +415,10 @@ airflow: | |||
## | |||
securityContext: {} | |||
|
|||
## the priorityClassName for the db-migrations Pods | |||
## | |||
priorityClassName: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a link for people who don't know what priorityClassName
is:
## the priorityClassName for the db-migrations Pods
## - docs for priorityClassName:
## https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
##
priorityClassName: ""
NOTE: we will also need to add it to all the other priorityClassName
docstrings in this values file
priorityClassName
priorityClassName
priorityClassName
What does your PR do?
Adds priorityClassName to pods
Checklist
For all Pull Requests
For releasing ONLY