Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add s3-sync sidecar option (breaking values changes) #782

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

benchoncy
Copy link

@benchoncy benchoncy commented Sep 5, 2023

What issues does your PR fix?

What does your PR do?

Note: This PR suggests interface changes with dags.gitSync values. May need to be viewed in the context of #501.

  • Generalises the definition of gitSync to a general sync pod definition
  • Refactor dags.gitSync values to dags.sync
  • Add support for s3 sync under new dags.sync values
  • Amend value validation for gitSync and add new validation for s3
  • Update README to reflect changes

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Ben Stuart <ben@benstuart.ie>
Signed-off-by: Ben Stuart <ben@benstuart.ie>
Signed-off-by: Ben Stuart <ben@benstuart.ie>
Signed-off-by: Ben Stuart <ben@benstuart.ie>
Signed-off-by: Ben Stuart <ben@benstuart.ie>
Signed-off-by: Ben Stuart <ben@benstuart.ie>
@jdobyns
Copy link

jdobyns commented Nov 9, 2023

Whats the hold up on this?

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Mar 13, 2024
@thesuperzapper thesuperzapper removed the lifecycle/stale lifecycle - this is stale label Mar 13, 2024
@thesuperzapper thesuperzapper changed the title feat: Add s3 sync sidecar option feat: add s3-sync sidecar option (breaking values changes) May 1, 2024
@benchoncy
Copy link
Author

@thesuperzapper Considering there is now a competing pull request for the same feature #828, which appears to have gotten more discussion, should I close this pull request? There are now conflicts, so I'm looking to determine if this is worth updating.

@thesuperzapper
Copy link
Member

@benchoncy I really do appreciate the effort you have put in.

However, I am exceptionally unlikely to release any breaking changes in the values for the foreseeable future, as it's just too much work for people to migrate.

If you think you can do a better job then the other PR at adding new values specifically for S3 (or something similar), then you're welcome to either update this PR or make a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support loading DAG definitions from S3 buckets
3 participants