Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add airflow.extraPodSpec value #806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hosade
Copy link

@Hosade Hosade commented Dec 1, 2023

What issues does your PR fix?

Ability to add misc. spec resources on pods

What does your PR do?

Add a extraPodSpec variable to allocate Spec of pods not anticipated by the chart.

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Romain Boutinaud <romain.boutinaud@lifen.fr>
@Hosade Hosade marked this pull request as ready for review December 1, 2023 08:32
Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Mar 13, 2024
@thesuperzapper
Copy link
Member

Bumping for bot.

@thesuperzapper
Copy link
Member

I am not sure this is a good idea, it will result in people breaking stuff and anyone who has such complex requirements can probably just fork the chart for their own purposes.

@Hosade Am I missing anything that might make this necessary?

@stale stale bot removed the lifecycle/stale lifecycle - this is stale label May 1, 2024
@thesuperzapper thesuperzapper added lifecycle/stale lifecycle - this is stale status/needs-discussion status - this needs discussion labels May 1, 2024
@stale stale bot removed the lifecycle/stale lifecycle - this is stale label May 1, 2024
@thesuperzapper thesuperzapper changed the title feat: add support for extra pod Spec feat: add airflow.extraPodSpec value May 1, 2024
@Hosade
Copy link
Author

Hosade commented May 2, 2024

I am not sure this is a good idea, it will result in people breaking stuff and anyone who has such complex requirements can probably just fork the chart for their own purposes.

@Hosade Am I missing anything that might make this necessary?

Hi, necessary, I don't know. Forking (and maintaining the fork) for something that simple is kind of a pain. This would not break any existing setup and does not seem to be more error prone than other k8s concepts that we can find in the chart (pdb, affinity...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/needs-discussion status - this needs discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants