Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chart name and overrides to airflow.fullname helper function #827

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ffais
Copy link

@ffais ffais commented Feb 15, 2024

What does your PR do?

This PR makes the following changes...

Added the Chart name as a suffix to the airflow.fullname function, this is very useful for recognizing the resources deployed by airflow chart when is a sub chart.

Added nameOverride and fullnameOverride to allow the user to customize resource suffixes.

Checklist

For all Pull Requests

For releasing ONLY

@ffais ffais marked this pull request as draft February 15, 2024 16:19
@ffais ffais marked this pull request as ready for review February 15, 2024 16:44
@ffais ffais force-pushed the add-chart-name-fullname-helper-function branch from b8cb353 to 52f9d96 Compare February 15, 2024 17:01
Signed-off-by: ffais <ffais@fbk.eu>
Signed-off-by: ffais <ffais@fbk.eu>
Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Apr 22, 2024
@thesuperzapper thesuperzapper added this to the airflow-8.10.0 milestone Apr 24, 2024
@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants