fix: Avoid turning all stream timeouts to TcpIdleTimeoutException #32047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Aug 23, 2023
He-Pin
reviewed
Aug 23, 2023
johanandren
force-pushed
the
wip-tcp-idle-timeout-with-less-fuzz
branch
from
9d40492
to
d879eb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure this is the right thing but in akka/akka-http#4289 we noticed that
StreamIdleTimeoutExceptions in the stream not originating from the TCP idle timeouts would still be turned intoTcpIdleTimeoutException.This also eliminates at least one operator in each TCP stream materialization.