chore: Scalafmt upgrade #32187
chore: Scalafmt upgrade #32187
Conversation
| @@ -35,8 +35,11 @@ final case class SerializationCheckFailedException private[dungeon] (msg: Object | |||
| @InternalApi | |||
| private[akka] trait Dispatch { this: ActorCell => | |||
|
|
|||
| // scalafmt breaks this by moving the _ to its own line which doesn't compile | |||
There was a problem hiding this comment.
Interaction of breaking long lines in scalafmt with the semicolon inference in at least Scala 3.3.1
There was a problem hiding this comment.
I looked at some (random) formatting changes. Overall looks pretty good.
Noted a few annoying things
/** INTERNAL API */
will be broken up in 3 lines
props.args.forall(
arg =>
it was more compact
props.args.forall(arg =>
extra ( ) around function parameter
(ex) => shouldRetry.test(ex),
|
if we approve this change we should apply it to release-2.8 branch to make it easier to backport fixes |
|
I believe the extra |
but it compiles fine without |
|
Scala 3 requires parens around single arguments with type ascriptions. Perhaps scalafmt also imposes the parens for its Scala 3-compatible modes? |
|
As noticed in another repo, |
Draft for now (the formatting changes that result are omitted).
Some of the previous scalafmt settings have no direct equivalent in modern scalafmt, so the diff will be something to behold. Leaving out the resulting formatting changes to facilitate local playing around with the settings.
passes.
References #32186 and #32083.